Bedste fremgangsmåder til en ren og effektiv vinkelapplikation

Jeg har arbejdet med en stor skala Angular-applikation hos Trade Me, New Zealand i et par år nu. I løbet af de sidste par år har vores team forbedret vores ansøgning både med hensyn til kodningsstandarder og ydeevne for at gøre det i den bedst mulige tilstand.

Denne artikel beskriver de fremgangsmåder, vi bruger i vores applikation og er relateret til Angular, Typescript, RxJs og @ ngrx / store. Vi gennemgår også nogle generelle retningslinjer for kodning for at gøre applikationen renere.

1) trackBy

Når du bruger ngFortil at sløjfe over en matrix i skabeloner, skal du bruge den med en trackByfunktion, der returnerer en unik identifikator for hvert element.

Hvorfor?

Når en matrix ændres, gengiver Angular hele DOM-træet igen. Men hvis du bruger trackBy, vil Angular vide, hvilket element der er ændret, og kun foretage DOM-ændringer for det pågældende element.

For en detaljeret forklaring på dette henvises til denne artikel af Netanel Basal.

Før

  • {{ item }}
  • Efter

    // in the template 
  • {{ item }}
  • // in the component trackByFn(index, item) { return item.id; // unique id corresponding to the item }

    2) const vs let

    Brug const, når værdien erklæres for variabler, ikke tildeles igen.

    Hvorfor?

    Brug letog, consthvor det er relevant, gør hensigten med erklæringerne klarere. Det vil også hjælpe med at identificere problemer, når en værdi tildeles en konstant ved et uheld ved at kaste en kompileringstidsfejl. Det hjælper også med at forbedre læsbarheden af ​​koden.

    Før

    let car = 'ludicrous car'; let myCar = `My ${car}`; let yourCar = `Your ${car}; if (iHaveMoreThanOneCar) { myCar = `${myCar}s`; } if (youHaveMoreThanOneCar) { yourCar = `${youCar}s`; }

    Efter

    // the value of car is not reassigned, so we can make it a const const car = 'ludicrous car'; let myCar = `My ${car}`; let yourCar = `Your ${car}; if (iHaveMoreThanOneCar) { myCar = `${myCar}s`; } if (youHaveMoreThanOneCar) { yourCar = `${youCar}s`; }

    3) Rørbare operatører

    Brug rørførbare operatører, når du bruger RxJs-operatører.

    Hvorfor?

    Rørbare operatører kan rystes i træ, hvilket betyder, at kun den kode, vi skal udføre, vil blive inkluderet, når de importeres.

    Dette gør det også let at identificere ubrugte operatorer i filerne.

    Bemærk: Dette kræver Angular version 5.5+.

    Før

    import 'rxjs/add/operator/map'; import 'rxjs/add/operator/take'; iAmAnObservable .map(value => value.item) .take(1);

    Efter

    import { map, take } from 'rxjs/operators'; iAmAnObservable .pipe( map(value => value.item), take(1) );

    4) Isolér API-hacks

    Ikke alle API'er er skudsikre - nogle gange er vi nødt til at tilføje nogle logik i koden for at kompensere for fejl i API'erne. I stedet for at have hacks i komponenter, hvor de er nødvendige, er det bedre at isolere dem ét sted - som i en tjeneste og bruge tjenesten fra komponenten.

    Hvorfor?

    Dette hjælper med at holde hackerne "tættere på API", så så tæt på hvor netværksanmodningen fremsættes som muligt. På denne måde beskæftiger mindre af din kode sig med den ikke-hackede kode. Det er også et sted, hvor alle hackene bor, og det er lettere at finde dem. Når du retter bugs i API'erne, er det lettere at kigge efter dem i en fil i stedet for at kigge efter de hacks, der kunne spredes over kodebasen.

    Du kan også oprette brugerdefinerede tags som API_FIX svarende til TODO og tagge rettelserne med det, så det er lettere at finde.

    5) Abonner i skabelon

    Undgå at abonnere på observerbare fra komponenter, og abonner i stedet på de observerbare fra skabelonen.

    Hvorfor?

    asyncrør afmelde sig automatisk, og det gør koden enklere ved at eliminere behovet for manuelt at administrere abonnementer. Det reducerer også risikoen for ved et uheld at glemme at afmelde et abonnement på komponenten, hvilket kan forårsage en hukommelseslækage. Denne risiko kan også mindskes ved hjælp af en fnugregel til at detektere observerede observationer, der ikke er abonneret.

    Dette forhindrer også komponenter i at være stateful og introducerer fejl, hvor dataene bliver muteret uden for abonnementet.

    Før

    // // template 

    {{ textToDisplay }}

    // component iAmAnObservable .pipe( map(value => value.item), takeUntil(this._destroyed$) ) .subscribe(item => this.textToDisplay = item);

    Efter

    // template 

    { textToDisplay$ }

    // component this.textToDisplay$ = iAmAnObservable .pipe( map(value => value.item) );

    6) Ryd op i abonnementer

    Når du abonnerer på observable, altid sørge for du afmelde dem korrekt ved at bruge operatørerne kan lide take, takeUntilosv

    Hvorfor?

    Failing to unsubscribe from observables will lead to unwanted memory leaks as the observable stream is left open, potentially even after a component has been destroyed / the user has navigated to another page.

    Even better, make a lint rule for detecting observables that are not unsubscribed.

    Before

    iAmAnObservable .pipe( map(value => value.item) ) .subscribe(item => this.textToDisplay = item);

    After

    Using takeUntil when you want to listen to the changes until another observable emits a value:

    private _destroyed$ = new Subject(); public ngOnInit (): void { iAmAnObservable .pipe( map(value => value.item) // We want to listen to iAmAnObservable until the component is destroyed, takeUntil(this._destroyed$) ) .subscribe(item => this.textToDisplay = item); } public ngOnDestroy (): void { this._destroyed$.next(); this._destroyed$.complete(); }

    Using a private subject like this is a pattern to manage unsubscribing many observables in the component.

    Using take when you want only the first value emitted by the observable:

    iAmAnObservable .pipe( map(value => value.item), take(1), takeUntil(this._destroyed$) ) .subscribe(item => this.textToDisplay = item);

    Note the usage of takeUntil with take here. This is to avoid memory leaks caused when the subscription hasn’t received a value before the component got destroyed. Without takeUntil here, the subscription would still hang around until it gets the first value, but since the component has already gotten destroyed, it will never get a value — leading to a memory leak.

    7) Use appropriate operators

    When using flattening operators with your observables, use the appropriate operator for the situation.

    switchMap: when you want to ignore the previous emissions when there is a new emission

    mergeMap: when you want to concurrently handle all the emissions

    concatMap: when you want to handle the emissions one after the other as they are emitted

    exhaustMap: when you want to cancel all the new emissions while processing a previous emisssion

    For a more detailed explanation on this, please refer to this article by Nicholas Jamieson.

    Why?

    Using a single operator when possible instead of chaining together multiple other operators to achieve the same effect can cause less code to be shipped to the user. Using the wrong operators can lead to unwanted behaviour, as different operators handle observables in different ways.

    8) Lazy load

    When possible, try to lazy load the modules in your Angular application. Lazy loading is when you load something only when it is used, for example, loading a component only when it is to be seen.

    Why?

    This will reduce the size of the application to be loaded and can improve the application boot time by not loading the modules that are not used.

    Before

    // app.routing.ts { path: 'not-lazy-loaded', component: NotLazyLoadedComponent }

    After

    // app.routing.ts { path: 'lazy-load', loadChildren: 'lazy-load.module#LazyLoadModule' } // lazy-load.module.ts import { NgModule } from '@angular/core'; import { CommonModule } from '@angular/common'; import { RouterModule } from '@angular/router'; import { LazyLoadComponent } from './lazy-load.component'; @NgModule({ imports: [ CommonModule, RouterModule.forChild([ { path: '', component: LazyLoadComponent } ]) ], declarations: [ LazyLoadComponent ] }) export class LazyModule {}

    9) Avoid having subscriptions inside subscriptions

    Sometimes you may want values from more than one observable to perform an action. In this case, avoid subscribing to one observable in the subscribe block of another observable. Instead, use appropriate chaining operators. Chaining operators run on observables from the operator before them. Some chaining operators are: withLatestFrom, combineLatest, etc.

    Before

    firstObservable$.pipe( take(1) ) .subscribe(firstValue => { secondObservable$.pipe( take(1) ) .subscribe(secondValue => { console.log(`Combined values are: ${firstValue} & ${secondValue}`); }); });

    After

    firstObservable$.pipe( withLatestFrom(secondObservable$), first() ) .subscribe(([firstValue, secondValue]) => { console.log(`Combined values are: ${firstValue} & ${secondValue}`); });

    Why?

    Code smell/readability/complexity: Not using RxJs to its full extent, suggests developer is not familiar with the RxJs API surface area.

    Performance: If the observables are cold, it will subscribe to firstObservable, wait for it to complete, THEN start the second observable’s work. If these were network requests it would show as synchronous/waterfall.

    10) Avoid any; type everything;

    Always declare variables or constants with a type other than any.

    Why?

    When declaring variables or constants in Typescript without a typing, the typing of the variable/constant will be deduced by the value that gets assigned to it. This will cause unintended problems. One classic example is:

    const x = 1; const y = 'a'; const z = x + y; console.log(`Value of z is: ${z}` // Output Value of z is 1a

    This can cause unwanted problems when you expect y to be a number too. These problems can be avoided by typing the variables appropriately.

    const x: number = 1; const y: number = 'a'; const z: number = x + y; // This will give a compile error saying: Type '"a"' is not assignable to type 'number'. const y:number

    This way, we can avoid bugs caused by missing types.

    Another advantage of having good typings in your application is that it makes refactoring easier and safer.

    Consider this example:

    public ngOnInit (): void { let myFlashObject = { name: 'My cool name', age: 'My cool age', loc: 'My cool location' } this.processObject(myFlashObject); } public processObject(myObject: any): void { console.log(`Name: ${myObject.name}`); console.log(`Age: ${myObject.age}`); console.log(`Location: ${myObject.loc}`); } // Output Name: My cool name Age: My cool age Location: My cool location

    Let us say, we want to rename the property loc to location in myFlashObject:

    public ngOnInit (): void { let myFlashObject = { name: 'My cool name', age: 'My cool age', location: 'My cool location' } this.processObject(myFlashObject); } public processObject(myObject: any): void { console.log(`Name: ${myObject.name}`); console.log(`Age: ${myObject.age}`); console.log(`Location: ${myObject.loc}`); } // Output Name: My cool name Age: My cool age Location: undefined

    If we do not have a typing on myFlashObject, it thinks that the property loc on myFlashObject is just undefined rather than that it is not a valid property.

    If we had a typing for myFlashObject, we would get a nice compile time error as shown below:

    type FlashObject = { name: string, age: string, location: string } public ngOnInit (): void { let myFlashObject: FlashObject = { name: 'My cool name', age: 'My cool age', // Compilation error Type '{ name: string; age: string; loc: string; }' is not assignable to type 'FlashObjectType'. Object literal may only specify known properties, and 'loc' does not exist in type 'FlashObjectType'. loc: 'My cool location' } this.processObject(myFlashObject); } public processObject(myObject: FlashObject): void { console.log(`Name: ${myObject.name}`); console.log(`Age: ${myObject.age}`) // Compilation error Property 'loc' does not exist on type 'FlashObjectType'. console.log(`Location: ${myObject.loc}`); }

    If you are starting a new project, it is worth setting strict:true in the tsconfig.json file to enable all strict type checking options.

    11) Make use of lint rules

    tslint has various options built in already like no-any, no-magic-numbers, no-console, etc that you can configure in your tslint.json to enforce certain rules in your code base.

    Why?

    Having lint rules in place means that you will get a nice error when you are doing something that you should not be. This will enforce consistency in your application and readability. Please refer here for more rules that you can configure.

    Some lint rules even come with fixes to resolve the lint error. If you want to configure your own custom lint rule, you can do that too. Please refer to this article by Craig Spence on how to write your own custom lint rules using TSQuery.

    Before

    public ngOnInit (): void { console.log('I am a naughty console log message'); console.warn('I am a naughty console warning message'); console.error('I am a naughty console error message'); } // Output No errors, prints the below on console window: I am a naughty console message I am a naughty console warning message I am a naughty console error message

    After

    // tslint.json { "rules": { ....... "no-console": [ true, "log", // no console.log allowed "warn" // no console.warn allowed ] } } // ..component.ts public ngOnInit (): void { console.log('I am a naughty console log message'); console.warn('I am a naughty console warning message'); console.error('I am a naughty console error message'); } // Output Lint errors for console.log and console.warn statements and no error for console.error as it is not mentioned in the config Calls to 'console.log' are not allowed. Calls to 'console.warn' are not allowed.

    12) Small reusable components

    Extract the pieces that can be reused in a component and make it a new one. Make the component as dumb as possible, as this will make it work in more scenarios. Making a component dumb means that the component does not have any special logic in it and operates purely based on the inputs and outputs provided to it.

    As a general rule, the last child in the component tree will be the dumbest of all.

    Why?

    Reusable components reduce duplication of code therefore making it easier to maintain and make changes.

    Dumb components are simpler, so they are less likely to have bugs. Dumb components make you think harder about the public component API, and help sniff out mixed concerns.

    13) Components should only deal with display logic

    Avoid having any logic other than display logic in your component whenever you can and make the component deal only with the display logic.

    Why?

    Components are designed for presentational purposes and control what the view should do. Any business logic should be extracted into its own methods/services where appropriate, separating business logic from view logic.

    Business logic is usually easier to unit test when extracted out to a service, and can be reused by any other components that need the same business logic applied.

    14) Avoid long methods

    Long methods generally indicate that they are doing too many things. Try to use the Single Responsibility Principle. The method itself as a whole might be doing one thing, but inside it, there are a few other operations that could be happening. We can extract those methods into their own method and make them do one thing each and use them instead.

    Why?

    Long methods are hard to read, understand and maintain. They are also prone to bugs, as changing one thing might affect a lot of other things in that method. They also make refactoring (which is a key thing in any application) difficult.

    This is sometimes measured as “cyclomatic complexity”. There are also some TSLint rules to detect cyclomatic/cognitive complexity, which you could use in your project to avoid bugs and detect code smells and maintainability issues.

    15) DRY

    Do not Repeat Yourself. Make sure you do not have the same code copied into different places in the codebase. Extract the repeating code and use it in place of the repeated code.

    Why?

    Having the same code in multiple places means that if we want to make a change to the logic in that code, we have to do it in multiple places. This makes it difficult to maintain and also is prone to bugs where we could miss updating it in all occurrences. It takes longer to make changes to the logic and testing it is a lengthy process as well.

    In those cases, extract the repeating code and use it instead. This means only one place to change and one thing to test. Having less duplicate code shipped to users means the application will be faster.

    16) Add caching mechanisms

    When making API calls, responses from some of them do not change often. In those cases, you can add a caching mechanism and store the value from the API. When another request to the same API is made, check if there is a value for it in the cache and if so, use it. Otherwise, make the API call and cache the result.

    If the values change but not frequently, you can introduce a cache time where you can check when it was last cached and decide whether or not to call the API.

    Why?

    Having a caching mechanism means avoiding unwanted API calls. By only making the API calls when required and avoiding duplication, the speed of the application improves as we do not have to wait for the network. It also means we do not download the same information over and over again.

    17) Avoid logic in templates

    If you have any sort of logic in your templates, even if it is a simple && clause, it is good to extract it out into its component.

    Why?

    Having logic in the template means that it is not possible to unit test it and therefore it is more prone to bugs when changing template code.

    Before

    // template 

    Status: Developer

    // component public ngOnInit (): void { this.role = 'developer'; }

    After

    // template 

    Status: Developer

    // component public ngOnInit (): void { this.role = 'developer'; this.showDeveloperStatus = true; }

    18) Strings should be safe

    If you have a variable of type string that can have only a set of values, instead of declaring it as a string type, you can declare the list of possible values as the type.

    Why?

    By declaring the type of the variable appropriately, we can avoid bugs while writing the code during compile time rather than during runtime.

    Before

    private myStringValue: string; if (itShouldHaveFirstValue) { myStringValue = 'First'; } else { myStringValue = 'Second' }

    After

    private myStringValue: 'First' | 'Second'; if (itShouldHaveFirstValue) { myStringValue = 'First'; } else { myStringValue = 'Other' } // This will give the below error Type '"Other"' is not assignable to type '"First" | "Second"' (property) AppComponent.myValue: "First" | "Second"

    Bigger picture

    State Management

    Consider using @ngrx/store for maintaining the state of your application and @ngrx/effects as the side effect model for store. State changes are described by the actions and the changes are done by pure functions called reducers.

    Why?

    @ngrx/store isolates all state related logic in one place and makes it consistent across the application. It also has memoization mechanism in place when accessing the information in the store leading to a more performant application. @ngrx/store combined with the change detection strategy of Angular leads to a faster application.

    Immutable state

    When using @ngrx/store, consider using ngrx-store-freeze to make the state immutable. ngrx-store-freeze prevents the state from being mutated by throwing an exception. This avoids accidental mutation of the state leading to unwanted consequences.

    Why?

    Mutating state in components leads to the app behaving inconsistently depending on the order components are loaded. It breaks the mental model of the redux pattern. Changes can end up overridden if the store state changes and re-emits. Separation of concerns — components are view layer, they should not know how to change state.

    Jest

    Jest is Facebook’s unit testing framework for JavaScript. It makes unit testing faster by parallelising test runs across the code base. With its watch mode, only the tests related to the changes made are run, which makes the feedback loop for testing way shorter. Jestalso provides code coverage of the tests and is supported on VS Code and Webstorm.

    You could use a preset for Jest that will do most of the heavy lifting for you when setting up Jest in your project.

    Karma

    Karma is a test runner developed by AngularJS team. It requires a real browser/DOM to run the tests. It can also run on different browsers. Jest doesn’t need chrome headless/phantomjs to run the tests and it runs in pure Node.

    Universal

    If you haven’t made your app a Universal app, now is a good time to do it. Angular Universal lets you run your Angular application on the server and does server-side rendering (SSR) which serves up static pre-rendered html pages. This makes the app super fast as it shows content on the screen almost instantly, without having to wait for JS bundles to load and parse, or for Angular to bootstrap.

    It is also SEO friendly, as Angular Universal generates static content and makes it easier for the web crawlers to index the application and make it searchable without executing JavaScript.

    Why?

    Universal improves the performance of your application drastically. We recently updated our application to do server side rendering and the site load time went from several seconds to tens of milliseconds!!

    Det giver også dit websted mulighed for korrekt at blive vist i uddrag af sociale medier. Den første meningsfulde maling er virkelig hurtig og gør indholdet synligt for brugerne uden uønskede forsinkelser.

    Konklusion

    Opbygning af applikationer er en konstant rejse, og der er altid plads til at forbedre tingene. Denne liste over optimeringer er et godt sted at starte, og ved at anvende disse mønstre konsekvent vil dit team være lykkeligt. Dine brugere vil også elske dig for den gode oplevelse med din mindre buggy og performante applikation.

    Tak fordi du læste! Hvis du nød denne artikel, er du velkommen til ? og hjælpe andre med at finde det. Tøv ikke med at dele dine tanker i kommentarfeltet nedenfor. Følg mig på Medium eller Twitter for flere artikler. Glade kodende folk !! ? ☕️